http2: submit RST_STREAM before emitting 'aborted' - #66314
Conversation
Signed-off-by: lazerg <lazerg2@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
http2
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66314 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 790 790
Lines 274273 274498 +225
Branches 52513 52569 +56
==========================================
+ Hits 247842 248085 +243
+ Misses 16897 16880 -17
+ Partials 9534 9533 -1
🚀 New features to boost your workflow:
|
panva
added
author ready
github-actions
Bot
removed
the
request-ci
pimterry
added
the
commit-queue
|
Landed in 1f26576 |
nodejs-github-bot
removed
the
commit-queue
aduh95
added
the
backport-requested-v26.x
|
This doesn't land cleanly on v26.x-staging, and would require a manual backport if we want it there |
6 participants
closeStream() emitted 'aborted' before submitting RST_STREAM. If an 'aborted' listener destroyed the stream (stream.pipeline() does this on its own), _destroy() skipped its RST because the stream was already marked closed, then destroyed the handle, so the later submitRstStream() found no handle and nothing was sent. The peer's stream stayed open until the session closed.
This emits 'aborted' after the RST_STREAM has been submitted.
Fixes: #66306